Comments on [WayBack] A Case Study in Not Being A Jerk in Open Source – Kevlin Henney – Google+:
- Jeroen Wiert Pluimers
+Kevin Powick yup. Maybe we need to learn to live with it.
At the current client I explained the teams that sometimes I do stupid things, both in code and in communications, and I expect them to tell me about them, just like I am telling them they do stupid things. Of course making compliments both ways work in a similar fashion.
We Dutch are accustomed to make compliments, so I am trying to break them out of the “Doe maar gewoon, dat is al gek genoeg”, as they already create very good stuff, but both they and I are convinced together we can take that to a next level.
Last week I did my first “Jeroen’s demo hour” showing stuff that happened in their development cycle over the last two weeks.
Somewhere in the first third was “look here: you see artifacts of some re-use by copy actions; it can be dangerous, just look at this obscure unnoticed bug. I need to watch myself, because sometimes I do this too”, and in the final 10 minutes while demoing some C# code – which is new to them – “look at this variable: it has the wrong name because I copy-pasted it, so if you review my code, just let me know how had this is”.
Maybe time to include some code review examples in a conference session topic…
Some ideas at The 10 commandments of navigating code reviews | TechBeacon
–jeroen
The Wiert Corner - irregular stream of stuff 